fix(ui): Handle null/undefined span.description safely #1239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use nullish coalescing operator instead of String() to prevent 'null' and 'undefined' literal strings from appearing as valid query/resource entries when span.description is not a string. Fixes SPOTLIGHT-ELECTRON-4V
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix runtime error when calling
.trim()on non-stringspan.descriptionvalues.Root Cause
The
Span.descriptionproperty is typed asstring | null | undefined. The previous code usedString(span?.description).trim()which converts:null→"null"(literal string)undefined→"undefined"(literal string)These incorrect values passed through the
.delete("")cleanup and appeared as valid queries/resources.Fix
Use nullish coalescing (
??) to return an empty string fornull/undefined, which the existing cleanup handles correctly:Fixes SPOTLIGHT-ELECTRON-4V